I was looking to change the storage method for avatars/uploads to s3, and I updated my FILESYSTEM_DISK
property on my Laravel .env file. However, avatar/uploads were still using the public disk.
According to the Upload Model, the disk being used is hardcoded. Wouldn't it be better to use the storage disk set in the .env file?
3 Comments
Yes, you're right - this should be configurable. Not necessarily using
FILESYSTEM_DISK
(as usually you want the app's default storage disk to be non-public), but by adding a new config option in Waterhole's config files. I've created an issue for tracking.In the meantime, if you're not using the
public
disk for anything else, you could update it to use thes3
driver and settings inconfig/filesystems.php
.Awesome, thanks Toby!
Ah, I see now. I always thought there was something wrong with my setup on Minio S3.