Toby's Comments
-
-
Toby Waterhole Founder
May 12, 2024 Thanks @Corrie Sloot, I've sent you an email.
-
Answer Toby Waterhole FounderMay 9, 2024 In reply to Emmanuel IngelaereEmmanuel IngelaereMay 9, 2024 All problems solved! After commenting out Model::shouldBeStrict(); in my project, the lazyloading error dissapeared. The control panel problem was actually an accidental space in the dutch translati...Hi @Emmanuel Ingelaere, thanks for posting and working through this issue transparently, and sorry for any inconvenience it's caused in your production environment.
While the bulk of
Model::shouldBeStrict()
issues were solved in v0.4.6, upon a little further digging, it looks like you uncovered a bug where a lazy loading error could still occur with some particular configurations of reactions - specifically, multiple reaction sets containing only a single reaction type. I've committed a fix for this which will be included in the next release.Thanks for your PR to fix the Dutch translation - a great first contribution!
-
- Support
- Open Source or Source Available?
Answer Toby Waterhole FounderMay 2, 2024 Thanks for the constructive discussion @Hellas and @Stormlight. I agree that the ambiguity is probably unhelpful, so I've changed all mentions of "open source" to the more precise "source available" on the website and docs.
-
- Development
- Laravel Integration
Toby Waterhole FounderApr 30, 2024 In reply to StormlightStormlightApr 16, 2024 Also, regarding conditional rendering, the use of a closure doesn't seem to work with the Extend remove method as it only accepts a string param. Is this method going to be updated in the future to al...Is there any way we can add traits to the Waterhole\Models\User class in a similar way as adding relationships via the resolveRelationUsing method?
Unfortunately I don't think it's currently possible to add traits to the Waterhole User model. Again, I'll look into making the User model configurable so you can subclass it, but for now your options are to implement the desired relations manually using
resolveRelationUsing
, or use your own separate User model/table and then set up the Laravel authentication integration.Also, regarding conditional rendering, the use of a closure doesn't seem to work with the Extend remove method as it only accepts a string param. Is this method going to be updated in the future to allow for mixed content instead of only strings?
Haven't tested, but try this:
$button = TextEditor::get('mention')['content']; TextEditor::replace('mention', fn(string $id) => $condition ? $button($id) : null);
-
Toby Waterhole Founder
Apr 28, 2024 This is obviously quite a small community, but runs on a $14/mo DigitalOcean droplet with 1 premium vCPU and 2GB of memory. It would likely run well on a cheaper droplet, but I want things to feel very fast
I'd also be interested to hear how Waterhole scales up in terms of server resources!
-
- Ideas
- GIF search
Toby Waterhole FounderApr 28, 2024 Thanks for the idea @David! This is something slightly too opinionated to include in the core product, but can definitely imagine a third-party extension providing this functionality.
-
- Ideas
- Support for Laravel 11?
Toby Waterhole FounderApr 28, 2024 In reply to StormlightStormlightApr 22, 2024 I think I figured out the issue, waterhole/core requires a beta version of turbo-laravel: waterhole/core v0.4.8 requires hotwired-laravel/turbo-laravel ^2.0.0-beta5 -> found hotwired-laravel/turbo-l...Great catch @Stormlight. I've updated the starter skeleton and tagged a new version.
-
- Blog
- Waterhole 0.4
Toby Waterhole FounderApr 28, 2024 In reply to RenéRenéApr 28, 2024 Hey @Toby! Any update on the next update? It's been a while. I like it as it is, but would certainly like to see more frequent development cycles. Cheers!Hi @René, thanks for checking in! Absolutely, I'm disappointed that I haven't been able to get the next release out the door yet. I think a combination of life being busy and the changes slated being relatively large/overwhelming has made it hard to find the chunks of time needed. I appreciate the nudge and am going to make a more concerted effort over the next month - stay tuned.
-
- Development
- Storage Options (s3 etc)
Answer Toby Waterhole FounderApr 28, 2024 Yes, you're right - this should be configurable. Not necessarily using
FILESYSTEM_DISK
(as usually you want the app's default storage disk to be non-public), but by adding a new config option in Waterhole's config files. I've created an issue for tracking.In the meantime, if you're not using the
public
disk for anything else, you could update it to use thes3
driver and settings inconfig/filesystems.php
. -
Toby Waterhole Founder
Apr 28, 2024 Hi @Emmanuel Ingelaere, if you revoke the "view" permission from guests for all of your forum's channels, pages, and links, then Waterhole will redirect visitors to the login screen instead of showing them the forum. It's probably desirable for there to be an easier way to do this - will keep in mind for a future improvement.
-
- Ideas
- Support for Laravel 11?
Toby Waterhole FounderApr 21, 2024 In reply to Ryan PittsRyan PittsApr 18, 2024 @Toby i have it all setup and running within my app now. The only part I'm a little stuck on is how do i get Waterhole to create user records in its users table for my existing users? I tried logging...@Ryan Pitts Can I clarify, what do you actually see when you navigate to the forum while logged in? The current behaviour is that Waterhole won't create the user immediately, but will present a pre-filled registration form allowing the user to customise their username. It shouldn't be possible to see a login screen if
password_enabled
is false and there are no authenticationproviders
in your config. -
- Ideas
- Support for Laravel 11?
Toby Waterhole FounderApr 21, 2024 In reply to StormlightStormlightApr 19, 2024 Hey Toby, I'm assuming 0.4.8 is yet to be released? As composer update doesn't pull in that version nor does starting a new project via composer create-project waterhole/waterhole path/to/forum.No it was released on 16 April! Maybe try clearing your Composer cache with
composer clear-cache
? -
- Ideas
- Support for Laravel 11?
Toby Waterhole FounderApr 16, 2024 In reply to Ryan PittsRyan PittsApr 8, 2024 Hey @Toby, just to try and test things out, i forked your repo and upgraded things to work with Laravel 11. I'm just having trouble with getting the assets CSS and js to load. I've not done much with...Laravel 11 support has been added in 0.4.8
@Ryan Pitts Hopefully you're able to switch back over to the official package - let me know if any issues. But for future reference, the command to compile Waterhole's assets is
npm run prod
. -
Toby Waterhole Founder
Apr 16, 2024 In reply to Tyler DuPontTyler DuPontApr 15, 2024 I noticed that when looking to tag people on my discussion board you cannot use spaces and there isn't a way to scroll on the suggested list. Not sure if it is possible to tag the person I am trying...Hey @Tyler DuPont, this is a great point. I've created an issue for this here which will aim to fix in a future version. As a workaround, if you're on a Mac you can hold down the Option key as you press the Space bar to continue filtering suggestions.
Just released v0.4.9 with @Emmanuel Ingelaere 's fix for this.